[OPENJDK-3396]Addition of a testcase for testing the jlink tech preview functionality. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew functionality.
|
Hi! Great job! Can you please a bit describe what it does and why it do what it do as it do it? |
|
@judovana Sure, The test case automation deploys the template onto the OCP cluster. Then validates the templates parameters. Next the test deploys an application using this template, validating the defined resources are created and available on the OCP cluster. Final it checks that the deployed App is up and running. Utility code was borrowed from historic eap testing. |
judovana
reviewed
Mar 11, 2025
| @@ -18,6 +18,9 @@ xtf.openjdk.17.version=17 | |||
| xtf.openjdk.21.image=registry.access.redhat.com/ubi8/openjdk-21:1.19-4 | |||
| xtf.openjdk.21.version=21 | |||
|
|
|||
| #Jlink template file location | |||
| xtf.openjdk.21.properties.template.url=https://raw.githubusercontent.com/rh-openjdk/redhat-openjdk-containers/refs/heads/jlink-dev/templates/jlink/jlinked-app.yaml | |||
There was a problem hiding this comment.
that have alot of A LOT OF parameters...
judovana
reviewed
Mar 11, 2025
| verifyExpectedResourcesCreated(); | ||
| // Validate the app is up | ||
| assertTrue(Https.doesUrlReturnCode("http://" + HOSTNAME, 200).waitFor()); | ||
| System.out.println("Statement."); |
There was a problem hiding this comment.
Statement? Just statement?-)
There was a problem hiding this comment.
I need to remove that. I was using it so I could study the assert with the debugger
test-openjdk/src/test/java/com/redhat/qe/openjdk/jlink/TemplateBuildTest.java
Show resolved
Hide resolved
|
Beginner question: How can I invoke the new |
|
@jmtd |
that was from the root, trying from Edit: same result. This is clearly just beginner's inexperience with running this stuff, but any more pointers greatly appreciated! |
|
@jmtd Looking now. |
|
The content of the test looks good to me, I'll try running it later and see if I can reproduce the issue Jon is seeing |
… HEAP space in the builds.
|
@jmtd @Josh-Matsuoka clean -DforkCount=0 test -P 21 -Dtest=TemplateBuildTest -Dmaven.home=/usr/share/maven Make sure to update your xtf.openjdk.21.image= value to your build under test. |
|
What is the recommended Java and Maven versions to execute this please? JDK21 and Maven 3.8.7 seems to result in |
|
@jmtd I'm running jdk 17 mvn 3.9.6 |
|
Unfortunately i still can't get mvn/? to find the class in the big backtrace, this is the bit that looks most useful Maven has actually built the test class, so that bit seems to work: |
Full backtrace: |
|
I think it's because i have not explicitly pointed xtf at an OCP instance. current guess |
jmtd
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test case to check the jlink template and test the app deployment and resource creation on an OpenShift cluster.