Updated checkAlgorithms.java to be compatible with JDK8 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ty! |
|
Interesting that original GH actions did not catch that. They run jdk8. Is th etes enabled to run as test inthis suite? It should |
|
From the looks of it, it is not, it was not run in the GH actions. Isn't that because it basically is just a file? There is no jtreg header in it. |
|
On longer run, it would be nice to have that header, at least for sake of GH in this project. |
|
Ok, I definitely agree. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says. I replaced
List.of()method withArrays.asList(), which should be JDK8 compatible.