rpmostree: Use --merge for kargs

Without `--merge`, all kernel arguments will be replaced, which is not what is desired in general. Especially with bootc karg support which we definitely want to work with Anaconda. Signed-off-by: Colin Walters <[email protected]> (cherry picked from commit cb7276e) Resolves: RHEL-73029
rhinstaller · Jan 30, 2025 · e8d8502 · e8d8502
1 parent 51cba8e
commit e8d8502
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 5 deletions.
diff --git a/pyanaconda/modules/payloads/payload/rpm_ostree/installation.py b/pyanaconda/modules/payloads/payload/rpm_ostree/installation.py
@@ -569,7 +569,7 @@ def _set_kargs(self):
             device_tree.GetDeviceData(root_name)
         )
 
-        set_kargs_args = ["admin", "instutil", "set-kargs"]
+        set_kargs_args = ["admin", "instutil", "set-kargs", "--merge"]
         set_kargs_args.extend(bootloader.GetArguments())
         set_kargs_args.append("root=" + device_tree.GetFstabSpec(root_name))
 

diff --git a/tests/unit_tests/pyanaconda_tests/modules/payloads/payload/test_rpm_ostree_tasks.py b/tests/unit_tests/pyanaconda_tests/modules/payloads/payload/test_rpm_ostree_tasks.py
@@ -706,8 +706,15 @@ def test_btrfs_run(self, devdata_mock, storage_mock, symlink_mock, rename_mock,
             )
             exec_mock.assert_called_once_with(
                 "ostree",
-                ["admin", "instutil", "set-kargs", "BOOTLOADER-ARGS", "root=FSTAB-SPEC",
-                 "rootflags=subvol=device-name", "rw"],
+                ["admin",
+                 "instutil",
+                 "set-kargs",
+                 "--merge",
+                 "BOOTLOADER-ARGS",
+                 "root=FSTAB-SPEC",
+                 "rootflags=subvol=device-name",
+                 "rw"
+                 ],
                 root=sysroot
             )
 
@@ -743,7 +750,14 @@ def test_nonbtrfs_run(self, devdata_mock, storage_mock, symlink_mock, rename_moc
             )
             exec_mock.assert_called_once_with(
                 "ostree",
-                ["admin", "instutil", "set-kargs", "BOOTLOADER-ARGS", "root=FSTAB-SPEC", "rw"],
+                ["admin",
+                 "instutil",
+                 "set-kargs",
+                 "--merge",
+                 "BOOTLOADER-ARGS",
+                 "root=FSTAB-SPEC",
+                 "rw"
+                 ],
                 root=sysroot
             )
 
@@ -826,7 +840,14 @@ def test_bootupd_run_with_leavebootorder(self, devdata_mock, storage_mock, symli
                 ),
                 call(
                     "ostree",
-                    ["admin", "instutil", "set-kargs", "BOOTLOADER-ARGS", "root=FSTAB-SPEC", "rw"],
+                    ["admin",
+                     "instutil",
+                     "set-kargs",
+                     "--merge",
+                     "BOOTLOADER-ARGS",
+                     "root=FSTAB-SPEC",
+                     "rw"
+                     ],
                     root=sysroot
                 )
             ])