Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation via docker obtains django-raster from user's repo #15

Closed
nesnoj opened this issue Aug 30, 2022 · 5 comments
Closed

Installation via docker obtains django-raster from user's repo #15

nesnoj opened this issue Aug 30, 2022 · 5 comments
Assignees
Labels
dependencies ⏫ Pull requests that update a dependency file

Comments

@nesnoj
Copy link
Member

nesnoj commented Aug 30, 2022

When installing via docker-compose -f local.yml up -d --build the raster functionality is obtained from @henhuy's repo as defined here (local mode):

Collecting git+https://github.com/henhuy/django-raster.git@djagora
  Cloning https://github.com/henhuy/django-raster.git (to revision djagora) to ./pip-req-build-vuv95b68
  Running command git clone --filter=blob:none --quiet https://github.com/henhuy/django-raster.git /tmp/pip-req-build-vuv95b68
  Running command git checkout -b djagora --track origin/djagora
  Switched to a new branch 'djagora'
  Branch 'djagora' set up to track remote branch 'djagora' from 'origin'.
  Resolved https://github.com/henhuy/django-raster.git to commit 3e5c5efb535e02a7884766cc22f77b284c822ba6
  Preparing metadata (setup.py): started
  Preparing metadata (setup.py): finished with status 'done'

The used version is 0.8.1 which is also available on pypi and should be replaced.

@nesnoj nesnoj added the dependencies ⏫ Pull requests that update a dependency file label Aug 30, 2022
@4lm
Copy link
Contributor

4lm commented Sep 7, 2022

The used version is 0.8.1 which is also available on pypi and should be replaced.

That's not possible. @henhuy wrote a patch for django-raster which never got merged into the original author's main branch (his PR is still open). The custom install points to a patched version (branch: djagora) in @henhuy's forked repo. His patched version should be used. I further improved the installation experience by including the patched dependency into the pyproject.toml, no need for an extra install step anymore. Will do PR now.

@nesnoj
Copy link
Member Author

nesnoj commented Sep 7, 2022

Thanks for this clarification and improved installation. It's a pity that it hasn't made its way into the original codebase yet.

I think this is ok for now but makes it impossible for us to publish our package on pypi in the future as only native pypi packages are allowed in the requirements (but no repos) - as far as I know.

@4lm
Copy link
Contributor

4lm commented Sep 7, 2022

I think this is ok for now but makes it impossible for us to publish our package on pypi in the future as only native pypi packages are allowed in the requirements (but no repos) - as far as I know.

I would say, a little bit more effort, but not impossible. geodesign/django-raster/ looks pretty abandoned. If the original author doesn't move, we could e.g. rename @henhuy's fork to django-rasteri - "i" for improved -, transfer the repo to the RLI org and publish our own package on PyPI. The beauty of open source 😉

Edit: further names suggestions, django-rastery, django-raster-v2

@henhuy
Copy link
Collaborator

henhuy commented Sep 8, 2022

on the other hand, I would not consider publishing it on pypi, as it is neither a library nor a framework (as it contains specific data not a generalized version of the tool). Nevertheless, If we would have a clean version of the tool (framework-style) this would be a important topic!

@4lm
Copy link
Contributor

4lm commented Sep 8, 2022

I talked to henhuy. We will touch this topic only, if we extract a clean version (framework, lib) of this project. Because this is not planned (for now) is will close this issue. Housekeeping.

@4lm 4lm closed this as completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies ⏫ Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

3 participants