Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install patched custom django-raster version via pyproject.toml (used py poetry) #17

Merged
merged 3 commits into from
Sep 12, 2022

Conversation

4lm
Copy link
Contributor

@4lm 4lm commented Sep 7, 2022

Hi @henhuy,

I have a PR in which I move the installation of your patched django-raster version (also see #15) into the pyproject.toml.

This was needed for all users who want to install locally via poetry (without Docker, as recommended in readme).

I also removed the extra step in local and production Dockerfiles.

Edit: I tested it with docker-compose -f local.yml up -d --build. Build process runs smooth. Didn't test it with production.yml (lack of production config), but I strongly assume that it will be OK too and would risk merging it.

Please review and merge, if you like what you see.

@4lm 4lm requested a review from henhuy September 7, 2022 13:51
@4lm
Copy link
Contributor Author

4lm commented Sep 12, 2022

@henhuy, this PR has to be merged in order for the my, in the readme, described install to work!

I know, you didn't merge it, because you are not sure if this works in production with Docker. I'm quite sure it works and would just merge it and fix later in the unlikely event that it breaks the production build (I mean, we are not in production yet, so who cares anyways)!

But in case if you insist on testing this specific detail first - can you maybe test it (build and run production Docker). Do you have a production config (I don't have one)? If you don't have time and won't merge without a production test first, please let me know, then I will create a production config and do a production test!

@henhuy
Copy link
Collaborator

henhuy commented Sep 12, 2022

Let's be crazy and merge it! ;)

@henhuy henhuy merged commit cbdd14a into dev Sep 12, 2022
@henhuy henhuy deleted the fix/install-of-custom-patched-django-raster-version branch September 12, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants