Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MUC Light affiliation change handling #1000

Merged

Conversation

pwetrifork
Copy link
Contributor

This pull requests fixes the following issues in MUC Light -xmppMUCLight:changedAffiliation:roomJID: callback:

  • The callback was only invoked once per incoming affiliation change message even if the server reported changes for several occupants.
  • The callback didn't include the JID of the occupant whose affiliation changed

The above fix is a prerequisite to introduce the last message correction handling module, one of the modules mentioned in the "Currently supported XMPP extensions" section in #993.

Technically, this pull request breaks XMPPMUCLightDelegate API. There are some good reasons to do so though:

  • MUC Light may still be considered as having "semi-experimental" status
  • The callback in its old form could misguide application developers leading to bugs where some affiliation changes go undetected

* Invoke MUC Light affiliation change delegate callback for individual occupants
* Include occupant JID in callback parameters
@chrisballinger chrisballinger merged commit 7fcf4c4 into robbiehanson:master Nov 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants