Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/chardet package version (issue #195) #197

Closed

Conversation

DarianAltF4
Copy link

@DarianAltF4 DarianAltF4 commented Oct 20, 2023

Description

Please include a summary of the change and which issue is fixed or implemented. Please also include relevant motivation and context (e.g. links, docs, tickets etc.).

Updated the chardet package from version 4.0.0 to version 5.0.0 in response to issue #195. The original request sought an upgrade to version 5.2, but this would have necessitated users to have Python version 3.7, while the current documentation recommends Python 3.6 and above. Version 5.0.0 of chardet is the highest available upgrade that maintains compatibility with Python 3.6+.

Type of change

  • Package update

How has this change been tested, please provide a testcase or example of how you tested the change?

Yes. All unit tests passed.

Any specific deployment considerations

For example, documentation changes, usability, usage/costs, secrets, etc.
No.

Docs

  • Docs updated? What were the changes:

@CLAassistant
Copy link

CLAassistant commented Nov 4, 2023

CLA assistant check
All committers have signed the CLA.

@capjamesg
Copy link
Collaborator

Can we use 5.2.0?

@telamonian telamonian mentioned this pull request Feb 23, 2024
1 task
@telamonian
Copy link

I opened an alternative to this PR at #230 that bumps chardet all the way up to the current version 5.2.0. This is now possible due to the fact that this project has since moved on to python>=3.8

@capjamesg
Copy link
Collaborator

I am going to close this in favour of #230. Please follow #230 for updates.

@capjamesg capjamesg closed this Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants