-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring dataset upload #312
Refactoring dataset upload #312
Conversation
… image_upload and save_annotation
@tonylampada I believe that the best way to solve this is to create exceptions for each type of error, making them be thrown from the rfapi layer, so that To be able to capture errors correctly in the CLI, I divided the responsibilities of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FANTASTIC.
Thank you @lrosemberg
Description
In PR #266, the way it was implemented changes the way the CLI displays the output, and also causes an error when trying to parse the response from upload_image.
In addition, some methods like
project.single_upload
had too many responsibilities, which made it difficult to handle exceptions correctly.That said, what does this PR do?
project.upload_image
andproject.save_annotation
, these start to be used insideproject.single_upload
andworkflow.upload_dataset
, isolating a good part of the code and keeping the functions with single responsibilityproject.upload
How has this change been tested, please provide a testcase or example of how you tested the change?
project.upload