feat(react): Allow passing a server snapshot to useQuery. #3686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables basic SSR/handoff.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tantaman
reviewed
Feb 3, 2025
| @@ -164,6 +183,7 @@ export class ViewStore { | |||
| clientID: string, | |||
| query: AdvancedQuery<TSchema, TTable, TReturn>, | |||
| enabled: boolean, | |||
| requireComplete: boolean, | |||
There was a problem hiding this comment.
switch to an options object now that we're at 2 boolean args?
| ); | ||
| // https://react.dev/reference/react/useSyncExternalStore | ||
| return useSyncExternalStore( | ||
| view.subscribeReactInternals, | ||
| view.getSnapshot, | ||
| view.getSnapshot, | ||
| serverSnapshot |
There was a problem hiding this comment.
Do you have an example of how someone uses zero on the server to populate this?
Something like this?
const q = z.query.issue.related('assignee');
export async function getServerSideProps() {
return { issues: await q.run() }
}
function MyComponent({issues}) {
const q = useQuery(q, {serverSnapshot: issues});
...
}Unclear to me how you hydrate a tree of components with SSR without one giant query at the root.
|
Sorry this wasn’t ready for review yet. Put into a draft pr to share early work with @jjenzz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables basic SSR/handoff.