wip: Aa/snake default #3718
Closed
wip: Aa/snake default #3718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making room for a new thing called NameMapper.
Feel like maybe I'm going about this wrong.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
darkgnotic
approved these changes
Feb 6, 2025
| @@ -56,12 +58,14 @@ export function createSchema< | |||
| >['relationships']; | |||
| }; | |||
| } { | |||
| const nameMapper = getNameMapper(options.nameMapping ?? 'snake'); | |||
There was a problem hiding this comment.
probably want the default to be 'none', so that we're not doing anything the user didn't ask for?
or do you think most users would expect us to map names to snake case? feels a bit magicky.
| case 'none': | ||
| return identity; | ||
| default: | ||
| return identity; |
There was a problem hiding this comment.
I think this can be:
default:
unreachable(nameMapping);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.