fix(zero-client): Allow overlapped mutators. #3757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Bencher Report| Branch | aa/overlapped-mutations |
| Testbed | localhost |
Click to view all benchmark results
| Benchmark | File Size | Benchmark Result kilobytes (KB) (Result Δ%) | Upper Boundary kilobytes (KB) (Limit %) |
|---|---|---|---|
| zero-package.tgz | 📈 view plot 🚷 view threshold | 950.46(-0.02%)Baseline: 950.64 | 969.65 (98.02%) |
| zero.js | 📈 view plot 🚷 view threshold | 178.98(-0.07%)Baseline: 179.10 | 182.68 (97.98%) |
| zero.js.br | 📈 view plot 🚷 view threshold | 49.78(-0.04%)Baseline: 49.79 | 50.79 (98.00%) |
|
| Branch | aa/overlapped-mutations |
| Testbed | localhost |
Click to view all benchmark results
| Benchmark | Throughput | Benchmark Result operations / second (ops/s) (Result Δ%) | Lower Boundary operations / second (ops/s) (Limit %) |
|---|---|---|---|
| src/client/zero.bench.ts > basics > All 1000 rows x 10 columns (numbers) | 📈 view plot 🚷 view threshold | 74.54(-0.49%)Baseline: 74.91 | 69.31 (92.99%) |
| src/client/zero.bench.ts > with filter > Lower rows 500 x 10 columns (numbers) | 📈 view plot 🚷 view threshold | 93.61(-0.94%)Baseline: 94.50 | 90.11 (96.26%) |
aboodman
force-pushed
the
aa/overlapped-mutations
branch
from
9d69ffd to
fb6d186
Compare
|
I would like to see/test what the push body looks like. All the calls to mutate inside a batch should be batched. I think this is where the problems show up. The CRUD mutators you get through the mutateBatch argument all get grouped into a single CRUD mutation. If you use z.mutate in there you will get multiple mutations and the order is probably not what you expect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugs.rocicorp.dev/issue/3529