Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rokita/update survival #9

Merged
merged 8 commits into from
Feb 24, 2025
Merged

Rokita/update survival #9

merged 8 commits into from
Feb 24, 2025

Conversation

jharenza
Copy link
Contributor

@jharenza jharenza commented Nov 26, 2024

Purpose/implementation Section

What scientific question is your analysis addressing?

This PR updates the survival analysis for CLK1 status:

  • for HGGs, to use only those differentially spliced across all HGGs (>2 SD lower than mean) as low and the top 12 as high.
  • for other cancers, to use those DS (>2 SD lower than mean) as the low clk1 exon 4 samples and those >1 SD from mean (>2 would be >1) as high.

I also removed NF1 scripts/code/outputs

What was your approach?

What GitHub issue does your pull request address?

Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.

Which areas should receive a particularly close look?

Is there anything that you want to discuss further?

Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?

Results

What types of results are included (e.g., table, figure)?

What is your summary of the results?

Reproducibility Checklist

  • The dependencies required to run the code in this pull request have been added to the project Dockerfile.

Documentation Checklist

  • This analysis module has a README and it is up to date.
  • The analytical code is documented and contains comments.

@jharenza jharenza requested a review from naqvia November 26, 2024 21:31
@jharenza jharenza requested review from rjcorb and removed request for naqvia December 10, 2024 21:48
@jharenza jharenza requested a review from naqvia January 6, 2025 16:06
@jharenza
Copy link
Contributor Author

jharenza commented Jan 6, 2025

@naqvia i think we can get this merged

@jharenza
Copy link
Contributor Author

@naqvia can you review pls

@jharenza jharenza removed the request for review from rjcorb February 19, 2025 15:43
Copy link
Collaborator

@naqvia naqvia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Scripts run as expected

@jharenza jharenza merged commit 7dc1655 into main Feb 24, 2025
@jharenza jharenza deleted the rokita/update-survival branch February 24, 2025 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants