Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unresolvable dependency, Rollbar should not be started when there… #169

Merged

Conversation

JerryVerhoef
Copy link

@JerryVerhoef JerryVerhoef commented Mar 13, 2025

Solution for #168

Description of the change

Rollbar cannot be initialized without key, this is a normal situation on development and test environments. Latest change broke this,

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

@mantas-done
Copy link

This fix works great!

Copy link
Collaborator

@danielmorell danielmorell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JerryVerhoef Thank you for submitting this! It's a perfect solution! Much appreciated!

@danielmorell danielmorell added this to the v8.1.1 milestone Mar 14, 2025
@danielmorell danielmorell merged commit f430c09 into rollbar:master Mar 14, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unresolvable Dependency in Rollbar\RollbarLogger Since v8.1.0 Error when no rollbar token for local testing
3 participants