Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to simple mode without fancy animation #130

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Jamagas
Copy link

@Jamagas Jamagas commented May 21, 2014

I needed just simple side menu without that fancy animations, so for convenient added simpleMode property for turning simple mode on.

Other reason why I do so was that without fancy animation I wasn't able to force pan to stop at content offset value and not pan more. This functionality wasn't present.

Besides side menu dim wasn't working right. When i was swiping from side, dim from 1 to 0 was changing in respect to view width and not in respect to content offset value (old code 533 line).

@lfarah
Copy link

lfarah commented Jan 7, 2015

This git is not updated for a while. What if we created a new git???

@Jamagas
Copy link
Author

Jamagas commented Jan 7, 2015

@lfarah 2-4 months after last update I do not consider inactive repo. Still 48 open issues is not a small number. Moreover, this issue is hanging here for a long time with no attention for whatever reason. Still, at this point I do not consider, that creating new repo is a solution. But if I will not see any more activity in this repo and no updates, for I believe a half year, then I will consider some alternatives, maybe on of them will be new repo.

@Jamagas
Copy link
Author

Jamagas commented Mar 25, 2015

@romaonthego Now this pull request hanging here from last year and get no attention and no response. Are these changes not relevant or what? I believe that some kind of feedback for all pull request is required from open source project managers or I'm I wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants