Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS validator/linter t9 GitHub Actions workflow #81

Merged
merged 12 commits into from
Aug 1, 2024
Merged

CSS validator/linter t9 GitHub Actions workflow #81

merged 12 commits into from
Aug 1, 2024

Conversation

Programmer80101
Copy link
Contributor

@Programmer80101 Programmer80101 commented Jul 31, 2024

CSS Linter

Add CSS linter to GitHub Actions workflow. It automatically catches CSS typos, errors, and issue.

It identified a significant number of issues.
Fix issue #80.
You can fix some of those errors by running the following code:

npx stylelint **/*.css --fix

Copy link
Member

@postmodern postmodern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed one minor thing with argument quoting.

.github/workflows/stylelint.yml Outdated Show resolved Hide resolved
@postmodern
Copy link
Member

postmodern commented Jul 31, 2024

@Programmer80101 any reason why we shouldn't use the actions-hub/stylelint GitHub Actions action? This looks ready to be merged, but just wanted to make sure there was a reason to not use the stylelint GitHub action.

@Programmer80101
Copy link
Contributor Author

@Programmer80101 any reason why we shouldn't use the actions-hub/stylelint GitHub Actions action? This looks ready to be merged, but just wanted to make sure there was a reason to not use the stylelint GitHub action.

Not using stylelint Github action allows more customization and flexibility. Using stylelint GitHub action is definitely better in some ways.

@postmodern postmodern merged commit d7bfd17 into ronin-rb:main Aug 1, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants