Remove rgdal dependency #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh I had missed this @olivroy sorry! Do you want write access? |
|
Thanks so much 🙏 |
Closed
|
@maelle Sure |
|
@olivroy sent you an invitation to the GitHub organization, and a team with admin access. Can you send me your email address so we can invite you to rOpenSci slack workspace? You're not forced to become a maintainer, but it's better you get the actual experience before you make a decision. 😇 |
|
Sure! Are we good with merging this first? |
|
You can merge this PR, unless you want me to review first? In which case I'd have a look next week. |
|
Can you send me your email address so we can invite you to rOpenSci slack workspace? |
|
Invite sent! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure I can be the maintainer as I did not understand how the source website may have evolved and what the expected results are. The tests and examples are lacking a little. I haven't gone through the article and vignette however.
However, I was able to fix #17 easily (the package doesn't seem to be using any rgdal functions)
I added a few refactoring here and there that may open the way to updating the package.