Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Required Validation of Nested Configs #9

Merged
merged 2 commits into from
Aug 19, 2024
Merged

Fix Required Validation of Nested Configs #9

merged 2 commits into from
Aug 19, 2024

Conversation

bbengfort
Copy link
Contributor

Scope of changes

Fixes a bug where "required" fields in nested configs were not being properly validated. Adds tests to make sure that nested structs and pointers are correctly validated and also adds a real world example just to make sure the configuration is happening correctly.

Fixes SC-20430

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Author checklist

  • I have manually tested the change and/or added automation in the form of unit tests or integration tests
  • I have added new test fixtures as needed to support added tests
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have moved the associated Shortcut story to "Ready for Review"

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • Are there any TODOs in this PR that should be turned into stories?

@bbengfort bbengfort requested a review from pdeziel August 19, 2024 16:04
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reflect.PtrTo is deprecated in favor of reflect.PointerTo.

Copy link
Collaborator

@pdeziel pdeziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, thanks for fixing the bug!

@bbengfort bbengfort merged commit 382af00 into main Aug 19, 2024
4 checks passed
@bbengfort bbengfort deleted the sc-20430 branch August 19, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants