Add optional chaining to reduce undefined errors #834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #24459: TypeError: Cannot read properties of undefined (reading 'status'). |
pdeziel
approved these changes
Mar 21, 2024
| @@ -17,7 +17,7 @@ export function useFetchMember(memberID: string): MemberQuery { | |||
| ...memberDetailQuery(memberID), | |||
| onError: (error: any) => { | |||
| // stop logging 401 & 403 errors to sentry | |||
| if (error.response.status !== 401 && error.response.status !== 403) { | |||
| if (error?.response?.status !== 401 && error?.response?.status !== 403) { | |||
There was a problem hiding this comment.
I am new to typescript and optional chaining - does this mean that if the error is undefined it will be not equal to both 401 and 403 and the exception will still be logged in the line below?
There was a problem hiding this comment.
Optional chaining, will check if the response object is null or undefined before attempting to read status. Currently, an error is thrown because the response hasn't been returned before attempting to read status.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope of changes
Adds optional chaining (
?.) to check if a property is undefined. This should reduce the number of undefined errors logged to Sentry.Fixes SC-24459
Type of change
Definition of Done
Reviewer(s) checklist