Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AccountType to Database #835

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Add AccountType to Database #835

merged 4 commits into from
Jul 3, 2024

Conversation

bbengfort
Copy link
Contributor

@bbengfort bbengfort commented Jun 29, 2024

Scope of changes

Rather than hardcoding the account type as "sandbox", the account type is saved in the database. This should allow us to update Rotational employee's account type so that they have access to the "paid" version rather than the sandbox version.

Fixes SC-24990

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

This is a tough one that could potentially inject a lot of bugs … let's read through this one carefully!

Definition of Done

  • I have manually tested the change running it locally (having rebuilt all containers) or via unit tests
  • I have added unit and/or integration tests that cover my changes
  • I have added new test fixtures as needed to support added tests
  • I have updated the dependencies list if necessary (including updating yarn.lock and/or go.sum)
  • I have recompiled and included new protocol buffers to reflect changes I made if necessary
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have notified the reviewer via Shortcut or Slack that this is ready for review
  • Backend-end: Documented service configuration changes or created related devops stories

Reviewer(s) checklist

  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • Are there any TODOs in this PR that should be turned into stories?

@bbengfort bbengfort marked this pull request as ready for review July 3, 2024 16:05
@bbengfort bbengfort merged commit 3e80961 into develop Jul 3, 2024
12 checks passed
@bbengfort bbengfort deleted the sc-24990 branch July 3, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant