Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade JS dependencies #837

Merged
merged 12 commits into from
Jul 26, 2024
Merged

Upgrade JS dependencies #837

merged 12 commits into from
Jul 26, 2024

Conversation

daniellemaxwell
Copy link
Contributor

@daniellemaxwell daniellemaxwell commented Jul 23, 2024

Scope of changes

This PR upgrades JS dependencies.

Fixes SC-26352

Type of change

  • new feature
  • bug fix
  • documentation
  • testing
  • technical debt
  • other (describe)

Acceptance criteria

[Copy acceptance criteria checklist from story for reviewer, or add a brief acceptance criteria here]

[Front-End: add screenshots/videos of changes made]

Definition of Done

  • I have manually tested the change running it locally (having rebuilt all containers) or via unit tests
  • I have added unit and/or integration tests that cover my changes
  • I have added new test fixtures as needed to support added tests
  • I have updated the dependencies list if necessary (including updating yarn.lock and/or go.sum)
  • I have recompiled and included new protocol buffers to reflect changes I made if necessary
  • Check this box if a reviewer can merge this pull request after approval (leave it unchecked if you want to do it yourself)
  • I have notified the reviewer via Shortcut or Slack that this is ready for review
  • Front-end: Checked sm, md, lg screen resolutions for effective responsiveness
  • Backend-end: Documented service configuration changes or created related devops stories

Reviewer(s) checklist

  • Front-end: I've reviewed the Figma design and confirmed that changes match the spec.
  • Any new user-facing content that has been added for this PR has been QA'ed to ensure correct grammar, spelling, and understandability.
  • Are there any TODOs in this PR that should be turned into stories?

@@ -5,7 +5,7 @@ import eslint from 'vite-plugin-eslint';
import svgrPlugin from 'vite-plugin-svgr';
import tsConfigPaths from 'vite-tsconfig-paths';
import { lingui } from '@lingui/vite-plugin';
import { VitePluginFonts } from 'vite-plugin-fonts';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was updated after learning via npm that the name changed.

Copy link
Contributor

@bbengfort bbengfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for helping us maintain these systems!

@daniellemaxwell daniellemaxwell merged commit de1f61d into develop Jul 26, 2024
12 checks passed
@daniellemaxwell daniellemaxwell deleted the sc-26352 branch July 26, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants