initial version manager fuzz test and testing doc #26
Conversation
There was a problem hiding this comment.
Thank you so much @eggyhead for continuing to push on this! I wasn't sure if you were ready for a review or not, so just wanted to check in. If you are ready for a review, I'll do a more thorough reading of the code, but everything looks great so far!
| @@ -23,4 +23,4 @@ Since fuzzing involves generating inputs at time intervals, you explicitly run t | |||
| Watch the output, and view any errors that may arise. When you are satisfied the tests confirm your code working as expected, you can exit the test. | |||
|
|
|||
| eg. | |||
| ` go test -fuzz=FuzzNewVersionManager -v` | |||
| ` go test -fuzz=FuzzVersionManager_Delete -v` | |||
There was a problem hiding this comment.
Do you think it would be a good idea to update GitHub actions with fuzzing? Alternatively, we could create a GitHub action that PRs don't depend on that performs fuzzing.
There was a problem hiding this comment.
Hi! Is this question about whether these tests will run automatically?
Currently, the fuzz tests will need to be run manually, as described in the doc.
| @@ -3,11 +3,12 @@ module github.com/rotationalio/honu | |||
| go 1.16 | |||
There was a problem hiding this comment.
We'll have to update this to go 1.19 for the tests to pass!
|
@eggyhead I'm sorry I haven't responded in a while, I wasn't sure if this was ready for review or not; things are looking great though and we're really excited to merge this PR - let me know! |
What are we doing?
Adding fuzz testing to the
rotationalversions test suite to increase coverage of edge cases.How are we doing it?
go-fuzz-headerslibrary to help with using structs in our testHow do I test?
follow the instructions in the test doc 😄