New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support queries on subscribe #65

Merged

pdeziel merged 1 commit into develop from sc-20592

Sep 21, 2023

Collaborator

pdeziel commented Sep 18, 2023

This PR allows queries to be passed in on subscribe.

I have made the following changes:

Refactor query parameter parsing, add test coverage
Add query arguments to the subscribe method

TODOs and questions

CHECKLIST

Is the commit message formatted correctly?

Do all of your functions and methods have docstrings?
Have you added/updated unit tests where appropriate?
Have you run the unit tests using pytest?
Is your code style correct (are you using PEP8, pyflakes)?


          support queries on subscribe

f25fd4b

shortcut-integration bot commented Sep 18, 2023

This pull request has been linked to Shortcut Story #20592: Ensure subscribe with query is compatible with Ensign.

pdeziel requested a review from rebeccabilbro

September 18, 2023 20:25

rebeccabilbro approved these changes

View reviewed changes

Member

rebeccabilbro left a comment

Looks good @pdeziel !

pdeziel merged commit f696f93 into develop

4 checks passed

pdeziel deleted the sc-20592 branch

September 21, 2023 18:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet