Add DataFrame class #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #22383: Explore streaming DataFrames. |
pdeziel
commented
Nov 3, 2023
| @@ -121,6 +121,9 @@ def get_description_type(path=PKG_DESCRIBE): | |||
| "download_url": "{}/tarball/v{}".format(REPOSITORY, get_version()), | |||
| "packages": find_packages(where=PROJECT, exclude=EXCLUDES), | |||
| "install_requires": list(get_requires()), | |||
| "extras_require": { | |||
| "ml": ["pandas==2.1.2"], | |||
There was a problem hiding this comment.
The idea is that we can make this an extra package e.g. pip install pyensign[ml], I'm not sure what else we need to do to make that happen but this ensures that pandas is not in the regular dependencies.
rebeccabilbro
approved these changes
Nov 6, 2023
There was a problem hiding this comment.
This is extremely cool @pdeziel! Once this is merged, maybe you could ask @pdamodaran to start experimenting a bit with these by installing from the develop branch?
tests/pyensign/ml/test_dataframe.py
Outdated
Comment on lines
141
to
142
| print(df) | ||
| print(expected) |
There was a problem hiding this comment.
Should we remove these prints?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an experimental package
mlwith an initial DataFrame implementation.TODOs and questions
CHECKLIST
pytest?