add signature template to new_user_dialog plugin #8983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecpl
requested changes
Aug 17, 2024
| @@ -19,9 +19,12 @@ class new_user_dialog extends rcube_plugin | |||
|
|
|||
| function init() | |||
| { | |||
| $rcmail = rcmail::get_instance(); | |||
| $this->load_config(); | |||
There was a problem hiding this comment.
FOr better performance loading config file should be done only when it's needed, i.e. not in init().
| $this->add_hook('identity_create', [$this, 'create_identity']); | ||
| $this->add_hook('render_page', [$this, 'render_page']); | ||
| $this->register_action('plugin.newusersave', [$this, 'save_data']); | ||
| $this->signature_text = $rcmail->config->get('new_user_dialog_signature_text'); |
There was a problem hiding this comment.
non-existing property warning. This can be a normal variable if you move it to render_page().
| @@ -89,6 +92,7 @@ function render_page($p) | |||
| 'name' => '_signature', | |||
| 'rows' => '5', | |||
| ], | |||
| $out = str_replace('@EMAIL@', rcube_utils::idn_to_utf8($identity['email']) , $this->signature_text ?? ''), | |||
| $identity['signature'] | |||
There was a problem hiding this comment.
This is wrong. If signature already exists (which could be set by another plugin) it should be used. $out variable is not needed here.
Also, it was missing before, but I think the content need to be encoded with rcube::Q().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the possibility to define a default signature. Additionally the signature email gets replaced with the user email if
@EMAIL@get added at the signature.To configure the default signature add this to the
config/config.inc.php$config['new_user_dialog_signature_text'] = ' ... ';Just for full transparency, I have no PHP skills. So while it works perfectly for me I have no real idea if this is "properly" done.