Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test message rendering #9460

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Test message rendering #9460

wants to merge 11 commits into from

Commits on Jun 14, 2024

  1. Exit only if not in TEST_MODE 

    We can't test this code if it exits.
    @pabzm
    pabzm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    4a79c8f View commit details
    Browse the repository at this point in the history

  2. Test message rendering 

    Run ./tests/MessageRendering/run-tests.sh to run all tests in that
directory, which are supposed to check the rendering of concrete
messages.

The messages are served by a dovecot container from the Maildir in
`tests/MessageRendering/src/maildir` and identified by their `Message-Id`.
    @pabzm
    pabzm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    7536fa4 View commit details
    Browse the repository at this point in the history

  3. Prevent phpstan from reporting skipped test as error

    @pabzm
    pabzm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    acad198 View commit details
    Browse the repository at this point in the history

  4. Rename message files to fix unit tests on windows 

    The files will be renamed back by dovecot, but then they won't hurt our
unit test suite anymore.
We'll have to come up with a good way to avoid git reporting a lot of
filename changes, though.
    @pabzm
    pabzm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    4846095 View commit details
    Browse the repository at this point in the history

  5. Exit script in a way that is mock'able

    @pabzm
    pabzm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    455d55a View commit details
    Browse the repository at this point in the history

  6. Rename folder containing test messages

    @pabzm
    pabzm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    4d435e6 View commit details
    Browse the repository at this point in the history

  7. Use CamelCase in new test files

    @pabzm
    pabzm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    770f545 View commit details
    Browse the repository at this point in the history

  8. Fix moving test files to data/

    @pabzm
    pabzm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    2abf095 View commit details
    Browse the repository at this point in the history

  9. Append to output, don't overwrite it

    @pabzm
    pabzm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    873204b View commit details
    Browse the repository at this point in the history

  10. Fix tests for code using sendExit()

    @pabzm
    pabzm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    e533e1d View commit details
    Browse the repository at this point in the history

  11. Allow to specify a different IMAP server container image 

    To use another image, e.g. to test a different server implementation, or
because the default image doesn't run on your platform, create a file
called 'tests/MessageRendering/.env' and assign the variable
ROUNDCUBE_TEST_IMAP_SERVER_IMAGE in it.
    @pabzm
    pabzm committed Jun 14, 2024
    Configuration menu
    Copy the full SHA
    63c90ef View commit details
    Browse the repository at this point in the history