Allow local downloads to same downloaddir
#2106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently when `dnf download --downloaddir <dir> <package>` sources`<package>` from `<dir>` it triggers a `shutil.SameFileError` exception and aborts the entire download process. This goes against the current flow which marks locally present RPMs that match a remote RPM as `[SKIPPED] <package>.rpm: Already downloaded`. This change allows downloads of locally sourced packages to the same file, treating it as a no-op.
m-blaha
approved these changes
Jul 2, 2024
There was a problem hiding this comment.
Purely out of curiosity - would you mind describing your use case that hits this exception? Downloading a package from a <local repository> back to the same <local repository> location seems a bit strange to me. Btw dnf5 (replacing dnf in F41) seems to work correctly here, marking the local package being downloaded as Already downloaded.
|
Many thanks for approving and checking this behavior in the newer version - we will look into moving to dnf5 - it is good to know we do not need to retain a workaround after upgrading.
The situation we are dealing with is two RPM-interdependent systems that are expected to both place and source their RPM artifacts using the same directory in order to reduce duplication, code complexity, and ordering (race conditions) runtime issues.
If we did not use a single directory for both systems then we would need to have a DNF-like synchronization mechanism between three different locations (one for each system and the local repository directory itself, which is consumed by external systems).
When either of the systems produces a newer version of an RPM, DNF download will pick the local repository version and that is when we see the ‘same file’ issue.
As a short-term solution, for a subset of the RPMs for one of the systems we use a separate directory and we sync that with the main (local repository) directory based on the header signature of the RPMs.
Thanks,
Nic
… On Jul 2, 2024, at 10:57 AM, Marek Blaha ***@***.***> wrote:
@m-blaha approved this pull request.
Purely out of curiosity - would you mind describing your use case that hits this exception? Downloading a package from a <local repository> back to the same <local repository> location seems a bit strange to me. Btw dnf5 (replacing dnf in F41) seems to work correctly here, marking the local package being downloaded as Already downloaded.
—
Reply to this email directly, view it on GitHub <#2106 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BA5VVYP7QEOHJAF7QBIX2FLZKJMNRAVCNFSM6AAAAABKBRV2E6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCNJSHE4TMNZVGY>.
You are receiving this because you authored the thread.
|
|
Any idea why check https://artifacts.dev.testing-farm.io/dbe646e2-d7a0-4ae6-9bc3-1e3feab1654c/ is failing? The only scenario the proposed code changes would fail is in a negative test, whereas this failure is during setup.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when
dnf download --downloaddir <dir> <package>sources<package>from<dir>it triggers ashutil.SameFileErrorexception and aborts the entire download process with a'<package>.rpm' and '<package>.rpm' are the same fileerror.This goes against the current flow which marks locally present RPMs that match a remote RPM as
[SKIPPED] <package>.rpm: Already downloaded.This change allows downloads of locally sourced packages to the same file, treating it as a no-op.