Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootc hosts message to point to bootc --help #2112

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

jmarrero
Copy link
Contributor

@jmarrero jmarrero commented Jul 19, 2024

Update bootc hosts message to point to bootc --help

@pep8speaks
Copy link

pep8speaks commented Jul 19, 2024

Hello @jmarrero! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-07-22 19:33:51 UTC

@jmarrero
Copy link
Contributor Author

expands on #2110

@jmarrero jmarrero changed the title Message bikeshed On a bootc host print the BOOTC_HOST_DOC if available. Jul 19, 2024
dnf/cli/cli.py Outdated Show resolved Hide resolved
dnf/util.py Outdated Show resolved Hide resolved
@ppisar
Copy link
Contributor

ppisar commented Jul 22, 2024

I don't like the idea with URL. Cannot ostree/bootc managaged host install a manual page and DNF simply referring that manual page? I guess the URL is supposed to document how to make a root file system writable.

We repeatedly get reports that DNF is used on disconnected systems and there pointing users to an on-line system is pointless.

@jlebon
Copy link
Contributor

jlebon commented Jul 22, 2024

I don't like the idea with URL. Cannot ostree/bootc managaged host install a manual page and DNF simply referring that manual page? I guess the URL is supposed to document how to make a root file system writable.

We repeatedly get reports that DNF is used on disconnected systems and there pointing users to an on-line system is pointless.

I think ideally we have both, but this is easier to get started. We're trying to minimize the amount of churn needed in dnf by planning ahead and conditionally keying off something outside dnf. Also, worth noting that manpages are very often stripped in minimal OS builds (that's the case in FCOS for example).

And of course, we can always improve things in follow-ups when there are less strict deadlines to deal with.

@jmarrero jmarrero changed the title On a bootc host print the BOOTC_HOST_DOC if available. Update bootc hosts message to point to bootc --help Jul 22, 2024
@jmarrero
Copy link
Contributor Author

Updating based on: #2110 (comment)

@jmarrero jmarrero marked this pull request as ready for review July 22, 2024 19:36
@dcantrell dcantrell self-requested a review July 23, 2024 13:59
@dcantrell dcantrell merged commit e253558 into rpm-software-management:master Jul 23, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants