Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: If DNF5 obsoletes DNF, do not build dnf and yum packages #2123

Conversation

ppisar
Copy link
Contributor

@ppisar ppisar commented Aug 19, 2024

Fedora CI installability and rpmdeplint tests failed on Fedoras where dnf5 obsoletes dnf and yum packages because the tests attempt to install just built dnf and yum packages, but DNF5 refuses installing them because they are obsoleted by an already installed dnf5:

 --------------------------------------------------------
|                                                        |
|   Running install test for dnf-0:4.21.0-3.fc41.noarch  |
|                                                        |
--------------------------------------------------------
Updating and loading repositories:
 Repo for 121841198 Brew build          100% |   4.7 MiB/s |   4.8 KiB |  00m00s
Repositories loaded.
Failed to resolve the transaction:
Problem: problem with installed package
  - installed package dnf5-5.2.5.0-2.fc41.x86_64 obsoletes dnf < 5 provided by dnf-4.21.0-3.fc41.noarch from brew-121841198
  - package dnf5-5.2.5.0-2.fc41.x86_64 from fedora obsoletes dnf < 5 provided by dnf-4.21.0-3.fc41.noarch from brew-121841198
  - package dnf5-5.2.5.0-2.fc41.x86_64 from updates obsoletes dnf < 5 provided by dnf-4.21.0-3.fc41.noarch from brew-121841198
  - package dnf5-5.2.5.0-2.fc41.x86_64 from rawhide obsoletes dnf < 5 provided by dnf-4.21.0-3.fc41.noarch from brew-121841198
  - package dnf5-5.2.5.0-2.fc41.x86_64 from fedora-41-buildroot obsoletes dnf < 5 provided by dnf-4.21.0-3.fc41.noarch from brew-121841198
  - package dnf5-5.2.5.0-2.fc41.x86_64 from testing-farm-tag-repository obsoletes dnf < 5 provided by dnf-4.21.0-3.fc41.noarch from brew-121841198
  - conflicting requests

(The same happesn for yum package.)

Solution this patch implements is not building the two obsolete packages. At the end, they cannot be installed.

Fedora CI installability and rpmdeplint tests failed on Fedoras where
dnf5 obsoletes dnf and yum packages because the tests attempt to
install just built dnf and yum packages, but DNF5 refuses installing
them because they are obsoleted by an already installed dnf5:

     --------------------------------------------------------
    |                                                        |
    |   Running install test for dnf-0:4.21.0-3.fc41.noarch  |
    |                                                        |
    --------------------------------------------------------
    Updating and loading repositories:
     Repo for 121841198 Brew build          100% |   4.7 MiB/s |   4.8 KiB |  00m00s
    Repositories loaded.
    Failed to resolve the transaction:
    Problem: problem with installed package
      - installed package dnf5-5.2.5.0-2.fc41.x86_64 obsoletes dnf < 5 provided by dnf-4.21.0-3.fc41.noarch from brew-121841198
      - package dnf5-5.2.5.0-2.fc41.x86_64 from fedora obsoletes dnf < 5 provided by dnf-4.21.0-3.fc41.noarch from brew-121841198
      - package dnf5-5.2.5.0-2.fc41.x86_64 from updates obsoletes dnf < 5 provided by dnf-4.21.0-3.fc41.noarch from brew-121841198
      - package dnf5-5.2.5.0-2.fc41.x86_64 from rawhide obsoletes dnf < 5 provided by dnf-4.21.0-3.fc41.noarch from brew-121841198
      - package dnf5-5.2.5.0-2.fc41.x86_64 from fedora-41-buildroot obsoletes dnf < 5 provided by dnf-4.21.0-3.fc41.noarch from brew-121841198
      - package dnf5-5.2.5.0-2.fc41.x86_64 from testing-farm-tag-repository obsoletes dnf < 5 provided by dnf-4.21.0-3.fc41.noarch from brew-121841198
      - conflicting requests

   (The same happesn for yum package.)

Solution this patch implements is not building the two obsolete
packages. At the end, they cannot be installed.
@ppisar
Copy link
Contributor Author

ppisar commented Aug 19, 2024

Here [https://src.fedoraproject.org/rpms/dnf/pull-request/24] is scratch build in Fedora, showing the Fedora CI results. As you can see, installability test passes. For unknown reason, other Fedora tests where not performed.

I tested this pull request in Fedora 42 where DNF5 obsoletes and in Fedora 40 where it does not. The two packages were correctly skipped in Fedora 42, while in Fedora 40 were correctly produced. No other changes was visible to the packages.

@jan-kolarik jan-kolarik self-assigned this Sep 6, 2024
Copy link
Member

@jan-kolarik jan-kolarik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jan-kolarik jan-kolarik merged commit f519e60 into rpm-software-management:master Sep 6, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants