rhel-9.6: Fixes for RHEL-49670 (bootc error message) #2127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anges Upstream commit: 5c050ba On ostree-based systems, users can use dnf to customize the environment but those changes will be lost at the next ostree-based image update. If you want to retain changes between ostree-updates you need to make use of rpm-ostree right now. Signed-off-by: David Cantrell <[email protected]> Resolves: https://issues.redhat.com/browse/RHEL-49670
ppisar
force-pushed
the
rhel-9.6-RHEL-49670
branch
3 times, most recently
from
9eba026
to
a4660fa
Compare
Upstream commit: 6120fe5 This changes the is_container() func for _is_bootc_host() and updates the logic and message. This should detect on all ostree and bootc hosts to date that are not using bootc usroverlay or ostree admin unlock for development purposes. Resolves: https://issues.redhat.com/browse/RHEL-49670
Upstream commit: e253558 Resolves: https://issues.redhat.com/browse/RHEL-49670
Upstream commit: a1aa8d0 Some people use --installroot on a read-only bootc system to install a system into a chroot subtree. However, current bootc check did not take into account --installroot and rejected the operation. This patch augments the check for the installroot being different from /. It's pointless to check for installroot writability here because installroot is written before this check when updating the repositories and computing a transaction. Moving this check sooner would not help because some directories (/opt, /) are kept read-only even on writable bootc. Resolves: rpm-software-management#2108 Resolves: https://issues.redhat.com/browse/RHEL-49670
ppisar
force-pushed
the
rhel-9.6-RHEL-49670
branch
from
a4660fa
to
d4da674
Compare
|
I hope a resolved all the white-speca PEP complains. I've never seen such a picky language as Python. |
|
This an amended respin of #2110. @dcantrell, can you review it? |
kontura
approved these changes
Sep 24, 2024
kontura
merged commit ca4c522
into
rpm-software-management:rhel-9.6
1 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set is a backport of the following upstream commits for rhel-9.6 branch:
Upstream commit: 5c050ba
Upstream commit: 6120fe5
Upstream commit: e253558
Upstream commit: a1aa8d0
Resolves: https://issues.redhat.com/browse/RHEL-49670