Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement --color flag #1750

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Reimplement --color flag #1750

wants to merge 1 commit into from

Conversation

alimirjamali
Copy link
Contributor

resolves: #839
related: QubesOS/qubes-issues#9482

@alimirjamali
Copy link
Contributor Author

alimirjamali commented Oct 2, 2024 •
edited
Loading

The fedora-39-* unit-tests failure were discussed here:
#1735 (comment)

I am not sure about other test failures with.
p.s.: All command aliases are broken. This should have nothing with my PR. The updated main branch before my PR has the same symptom. I will try to investigate and find the culprit which broke aliases.

p.s. Ok. The aliases broke since cmake's behaviour is changed with CMAKE_INSTALL_PREFIX. I am not sure if I should update the CMakeLists.txt file. I leave it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement --color flag and respect color option
1 participant
@alimirjamali