Support repo's Appstream data download and install #1844
Conversation
Repositories can provide Appstream data for the packages they contain. This Appstream data is consumed by applications like gnome-software or KDE Discover, thus the users can see the packages (apps) in them. This is to be in pair with PackageKit, which does download and install the repo's Appstream data. As this adds a dependency on the `appstream` library, there is also a CMake option WITH_APPSTREAM to be able to turn the support off. The support is enabled by default.
mcrha
force-pushed
the
wip/appstream-support
branch
from
c067fd1
to
a261aa3
Compare
|
Hrm, the CI either needs to add |
| void Repo::install_appstream() { | ||
| #ifdef WITH_APPSTREAM | ||
| std::string repo_id = p_impl->config.get_id(); | ||
| const char * as_basenames[] = {"appstream", "appstream-icons", NULL}; |
There was a problem hiding this comment.
this might not necessarily work when the appstream data is generated by the appstream-generator (instead of the appstream-builder), but I cannot test what the generator does in Fedora, because it's simply broken there.
Ideally, the get_metadata_path() might return a list of the repo files, which contain certain string, like in this case I'd call it appstream and any *appstream* files would be processed here, instead of knowing beforehand what file "types" can be used by whichever Appstream library and/or its version.
For example, the appstream-generator might create multiple appstream-icons files, each containing the icon size in its name, which is very bad approach, because the consumers need to be updated when the icon sizes change, to keep the list of the possible icon sizes in sync with the others.
There was a problem hiding this comment.
Note that appdata and appdata-icons are also used (by e.g. SUSE distributions).
Repositories can provide Appstream data for the packages they contain. This Appstream data is consumed by applications like gnome-software or KDE Discover, thus the users can see the packages (apps) in them.
This is to be in pair with PackageKit, which does download and install the repo's Appstream data.
As this adds a dependency on the
appstreamlibrary, there is also a CMake option WITH_APPSTREAM to be able to turn the support off. The support is enabled by default.That is, the
/var/cache/libdnf5/$REPO_NAME/repodata/directory can have downloaded also files withappstreamin their name and, when installed, the data is stored under/var/cache/swcatalog/xml/.CC @m-blaha @jan-kolarik