implement '$not' regex #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smyrman
requested changes
Sep 23, 2021
smyrman
reviewed
Sep 23, 2021
tsetsoo
pushed a commit
to tsetsoo/rest-layer
that referenced
this pull request
Sep 24, 2021
|
@smyrman Do you think we can go ahead and merge this PR? The regex functionality is needed regardless of whether we decide to support the ability to not the whole expression. |
|
Let's go ahead. Could you please squash your changes into one commit? Example: mark second commit as "fixup". |
tsetsoo
force-pushed
the
master
branch
2 times, most recently
from
eab2396
to
119039b
Compare
|
Done |
smyrman
previously approved these changes
Sep 30, 2021
smyrman
reviewed
Sep 30, 2021
smyrman
approved these changes
Sep 30, 2021
|
@rs: Seams travis is no longer working, so I can't merge this:
|
|
I removed the requirement for travis check before merging waiting for a github actions migration. |
Dragomir-Ivanov
pushed a commit
to Dragomir-Ivanov/rest-layer
that referenced
this pull request
May 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing
$notfilter operator with regex. It has the opposite function of$regex.Part of #273