Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

D2h visual #535

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

D2h visual #535

wants to merge 4 commits into from

Conversation

Santhip-msk
Copy link

Updated css for diff2html line folding..

Copy link
Owner

@rtfpessoa rtfpessoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me.
Before we can merge this there are a couple of things that need to be fixed:

  • As this changes the templates we need to release a new major version so you need to at least have breaking: in one of the commits for the version to be bumped
  • Test should be passing and we should add a couple of cases with the folding
  • Remove yarn.lock as we now use package-lock.json with npm and fix conflicts
  • Remove debugger statement
  • Update the readme with docs

Thanks a lot for your contribution, this is a great PR and lot's of people have requested this previously, so I think it will be loved.

Let me know if you need help with anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants