Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signatures #17

Closed
wants to merge 4 commits into from
Closed

Add signatures #17

wants to merge 4 commits into from

Conversation

Athishpranav2003
Copy link
Contributor

Added Ruby signatures for better debugging

@Athishpranav2003 Athishpranav2003 requested review from dipendra-singh, soni-himanshu and a team and removed request for soni-himanshu July 24, 2024 08:56
dipendra-singh
dipendra-singh suggested changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@dipendra-singh dipendra-singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please dont make this static typed. I dont think adding types in any way is helpful/necessary.

@Athishpranav2003
Copy link
Contributor Author

I see
These types help in further development but has little use in actual functioning
I will close this PR with a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipendra-singh dipendra-singh dipendra-singh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Athishpranav2003 @dipendra-singh