-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4473 expand reminder date possibilities #4606
base: main
Are you sure you want to change the base?
4473 expand reminder date possibilities #4606
Commits on Jul 22, 2024
-
Replaces reminder_day with reminder_schedule
Via db migrations, replaces the simple integer `reminder_day` with the more complex `reminder_schedule` which is an ical string that can be parsed to a repeating Schedule class. Adjusts the logic in the `fetch_partners_to_reminder_now_service` to use the repeating schedule. Updates related tests.
Configuration menu - View commit details
-
Copy full SHA for c7fee93 - Browse repository at this point
Copy the full SHA c7fee93View commit details
Commits on Aug 20, 2024
-
Adds input for the reminder schedule in the Edit Partner Group page
Builds an ActiveModel, ReminderSchedule, which takes the necessary information and turns it into an IceCubeSchedule, which is what ultimate get saved in the db. Builds the form for this reminder schedule. Still needs to conditionally show or hide sections depending on if the user wants date or day of the week.
Configuration menu - View commit details
-
Copy full SHA for 8363b88 - Browse repository at this point
Copy the full SHA 8363b88View commit details -
Adds Reminder Schedule fields to New and Edit Organization
Now either while creating new Organization/Partner Groups or editing them, all the transfers from Reminder Date to Reminder Day have been made.
Configuration menu - View commit details
-
Copy full SHA for 409209d - Browse repository at this point
Copy the full SHA 409209dView commit details
Commits on Aug 22, 2024
-
Makes the day of week or date hide depending on selection
This uses css for ease and accessibility.
Configuration menu - View commit details
-
Copy full SHA for 03cd829 - Browse repository at this point
Copy the full SHA 03cd829View commit details
Commits on Sep 4, 2024
-
Adds tests and does refactoring
Adds a number of refactors, including moving all the create_schedule logic to the deadlinable helper, and creates unit and system tests for the new functionality.
Configuration menu - View commit details
-
Copy full SHA for 80f6c02 - Browse repository at this point
Copy the full SHA 80f6c02View commit details
Commits on Sep 11, 2024
-
4473 - Makes same warning appear for reminder date
Reintroduces the functionality of having warnings for having the reminder date the same as the deadline date.
Configuration menu - View commit details
-
Copy full SHA for 8b2524a - Browse repository at this point
Copy the full SHA 8b2524aView commit details -
Merge remote-tracking branch 'upstream/main' into 4473-expand-reminde…
…r-date-possibilities
Configuration menu - View commit details
-
Copy full SHA for 64f7499 - Browse repository at this point
Copy the full SHA 64f7499View commit details
Commits on Sep 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 93cdebc - Browse repository at this point
Copy the full SHA 93cdebcView commit details
Commits on Sep 16, 2024
-
Only create new schedule if details have changed
We don't want to create a new schedule if nothing has changed, as it will reset the start date and potentially mess with those who have every 2/3/etc months reminders.
Configuration menu - View commit details
-
Copy full SHA for bea7a03 - Browse repository at this point
Copy the full SHA bea7a03View commit details -
Merge branch 'main' of https://github.com/rubyforgood/human-essentials …
…into 4473-expand-reminder-date-possibilities
Configuration menu - View commit details
-
Copy full SHA for 044e6bf - Browse repository at this point
Copy the full SHA 044e6bfView commit details
Commits on Sep 19, 2024
-
All reminders should be Monthly, so every N Months is removed. Also allows users to select "Last" as an option.
Configuration menu - View commit details
-
Copy full SHA for a0d1a65 - Browse repository at this point
Copy the full SHA a0d1a65View commit details
Commits on Oct 2, 2024
-
4473 - Updates names of Month vs Week fields
Rather than "date" and "week_day", we are now using "day_of_month" and "day_of_week" for clarity.
Configuration menu - View commit details
-
Copy full SHA for a14719c - Browse repository at this point
Copy the full SHA a14719cView commit details -
Merge remote-tracking branch 'upstream/main' into 4473-expand-reminde…
…r-date-possibilities
Configuration menu - View commit details
-
Copy full SHA for 9a5a757 - Browse repository at this point
Copy the full SHA 9a5a757View commit details
Commits on Oct 4, 2024
-
4473 - fixes reminder day vs deadline display bug
There was a bug in which if the reminder day of the month was the same as the deadline day, it would dislplay the error message even if the user changed to the day of the week option. Now the error message is hidden if the user is selecting the day of the week option.
Configuration menu - View commit details
-
Copy full SHA for 10833e0 - Browse repository at this point
Copy the full SHA 10833e0View commit details