Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export In Kind in donations csv #4661

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

jparcill
Copy link
Contributor

Resolves #4524

Description

Add column to the csv export for in kind value.

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added a test to see if the column exists

Screenshots

Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took this for a test-spin, and found that the in-kind value is being given in cents. We want it in dollars, please -- to 2 decimals. Thank you!

@jparcill
Copy link
Contributor Author

Sure! No other formatting other than that?

@jparcill
Copy link
Contributor Author

Done in this commit: c1449db

@jparcill
Copy link
Contributor Author

Formatted as money without the symbol

@cielf cielf merged commit 51ed96b into rubyforgood:main Sep 20, 2024
11 checks passed
Copy link
Contributor

@jparcill: Your PR Export In Kind in donations csv is part of today's Human Essentials production release: 2024.09.22.
Thank you very much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add In Kind value to Donation export
2 participants