-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4976 product drive participant dropdown fix #4997
base: main
Are you sure you want to change the base?
4976 product drive participant dropdown fix #4997
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @tbenny001 -- Thanks for taking this on!
At first it looked pretty good, but I tried the following sequence, and the blanks came back.
First I tried adding through the community|product drive participants -- looked good! --
Then I tried adding the product participant without a business name through the "Create New Participant" on the product participant field in New Donation. When I did that, the product participant was blank, and the product participants without business names were blank in the drop down when I looked at it
I'm sure it's something simple that just needs to be tweaked.
…down when no business name is available
134b134
to
a371ad1
Compare
Hey @cielf, sorry for the late response! I just pushed up the fix. It should work for the New Donation page as well now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good from a functional pov. Over to @dorner for any technical comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Looks good, but lint is failing and there is a merge conflict. |
Resolves #4976
Description
When creating a new donation and choosing Product Drive as the source, the Product Drive Participant drop down displays a blank entry when the participant has no business name. This PR addresses this issue by falling back to the contact name of the product drive participant if the participant does not have a business name.
Also adding DockerDesktopWSL/ to the .gitignore file
Type of change
How Has This Been Tested?
New Rspec tests and manual verification
Screenshots
Creating a Product Drive Participant with no business name:

Before:

After:
