4821-part1-partner-profile-support-multiple-attached-docs

[danielabar]

Partial solution for #4821

Description

This is the first part in a series of planned improvements for the "Additional Documents" section of Partner Profile editing.

Currently, even though the field is named in the plural "Additional Documents" and is using the has_many_attached association, in practice, the partner can only ever have one document at a time. Any time they upload a new one, it removes whatever was there previously.

What this fixes is to maintain the existing document(s), when a new one is uploaded, by including a hidden signed_id field for every document that is already attached. This solution is explained in the Rails Guide on Active Storage.

Note

This is only implemented in the step-wise version of the Partner Profile edit form as the legacy "all-in-one" version is no longer in use (and should eventually be retired - future ticket).

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

For automated testing, see new system test spec/system/partners/profile_edit_system_spec.rb "preserves previously uploaded documents when adding new attachments".

For manual testing:

• Login as an invited partner [email protected]
• Click on "Edit Profile" from the left hand side navigation
• Open the "Attached Documents" accordion section
• Upload a document and Save Progress
• Open the "Attached Documents" accordion section again and upload another document, and Save Progress
• Open the section and this time you should see both documents listed (previously only the newest one uploaded would be preserved)
• Optionally, you can also select multiple files at a time, they should all be saved, then if you come back to add more, originals plus anything new you added should all remain

Screenshots

[cielf]

Note for technical reviewer -- being able to remove them is a (hopefully fairly quick) follow-on.

[cielf]

I'll be trying this out on local, tonight or tomorrow, but I'd rather not put it out in the same release as #5023.

[cielf]

Looks good to me (given that this is a first step). Over to @dorner for technical comments.

[dorner]

Looks good to me! We can merge after the S3 stuff goes out.