feat: allow different client credentials for omniauth google #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phoet
reviewed
Jan 23, 2025
| provider :google_oauth2, { | ||
| verify_iss: false, | ||
| setup: proc do |env| | ||
| host = env['SERVER_NAME'] |
There was a problem hiding this comment.
might be a good idea to move the whole subdomain scrabble into some kind of helper since it's necessary for github tokens as well.
it might be worth pulling stuff into the Usergroup class and move initialization to a middleware so you dont have to do the subdomain handling twice (see WhitelabelDetection).
There was a problem hiding this comment.
extraction of whitelabel detection is done in #1108. This needs to be refactored so it uses the current Whitelabel to decide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to allow Tallinn.ruby.ee to authenticate with their own google app.