Add Amazon Bedrock Retriever to leverage Knowledge Base deployed onto AWS #1219
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
The retrievers shouldn't be in the llm folder, they should be one level higher in |
Thank you very much for your feedback @parhammmm |
Done, it was a mistake from my end @himself65 |
| type SearchType, | ||
| } from "@aws-sdk/client-bedrock-agent-runtime"; | ||
|
|
||
| import { BaseRetriever, Document } from "llamaindex"; |
There was a problem hiding this comment.
import Document from llamaindex/core/schema and copy BaseRetriever type here for now.
llamaindex is the to end user level pacakge and shouldn't be imported from our other pacakge, so please remove llamaindex from deps
remind me that we need move BaseRetriever into core module. If you are interested please follow python repo file structure and my other PR in this repo. Or I will do it tmr
There was a problem hiding this comment.
Thank you a lot for your review, please proceed with moving BaseRetriever into core module. Then, I will update code to import it if you are OKay @himself65?
Otherwise, I will copy BaseRetriever type here.
No description provided.