Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: store images in docstore #281

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

marcusschiesser
Copy link
Collaborator

In #280 the VectorIndexRetriever is retrieving image documents from the index and reconstructing their URL based on their ID (see https://github.com/run-llama/LlamaIndexTS/pull/280/files#r1427834636).

Suggestion:

  1. Store the images in the doc store (This PR stores images of ImageNodes base64 encoded in the doc store)
  2. Use the doc store to get the images in the VectorIndexRetriever

What are your thoughts?

Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
llama-index-ts-docs ✅ Ready (Inspect) Visit Preview Dec 15, 2023 10:53am

Copy link
Contributor

sweep-ai bot commented Dec 15, 2023

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

Base automatically changed from ms/add-multi-modal-rag to main December 18, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants