Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for the latest claude 3.7 sonnet models #17906

Closed
wants to merge 4 commits into from

Conversation

greg-niemeyer
Copy link
Contributor

@greg-niemeyer greg-niemeyer commented Feb 24, 2025

Description

Adds support for the latest Claude 3.7 release: https://docs.anthropic.com/en/docs/about-claude/models/all-models

New Package?

Did I fill in the tool.llamahub section in the pyproject.toml and provide a detailed README.md for my new integration or package?

  • Yes
  • No

Version Bump?

Did I bump the version in the pyproject.toml file of the package I am updating? (Except for the llama-index-core package)

  • Yes
  • No

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I added new unit tests to cover this change
  • I believe this change is already covered by existing unit tests

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added Google Colab support for the newly added notebooks.
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I ran make format; make lint to appease the lint gods

@Digma
Copy link
Contributor

Digma commented Feb 24, 2025

Thanks for the quick update.

Wondering if you got a chance to look at the thinking capabilities and how much work it would be to add them?

@greg-niemeyer
Copy link
Contributor Author

i have not looked into it and i probably don't have bandwidth to add that support, but if you want to take the PR over and do it that works for me too.

@greg-niemeyer
Copy link
Contributor Author

confirmed that the added support for 3.7 works using the anthropic SDK.

when attempting to run the bedrock test with 3.7, i get "Invocation of model ID anthropic.claude-3-7-sonnet-20250219-v1:0 with on-demand throughput isn’t supported", but it recognizes the model -- passing a bad name yields "The provided model identifier is invalid" instead.

similarly with vertex, i have to apply to get the model enabled for my project and get a "is not allowed to use Publisher Model [...] FAILED_PRECONDITION" error, whereas with a bad model id i get 'Publisher model [...] not found.'

@greg-niemeyer greg-niemeyer marked this pull request as ready for review February 24, 2025 21:36
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Feb 24, 2025
@greg-niemeyer
Copy link
Contributor Author

lol looks like llama-index devs already opened an earlier PR and merged the changes (#17905). closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants