Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Booster-532: align fourmolu and hlint versions #3756

Merged
merged 13 commits into from
Apr 4, 2024

Conversation

jberthold
Copy link
Member

@jberthold jberthold commented Apr 4, 2024

Preparing runtimeverification/hs-backend-booster#532

  • Use fourmolu 0.14.0.0, reformatting the code as required (large change)
  • use hlint-3.6.1 to check code style (adjusting code and config as required)
  • provide hlint-3.6.1 in nix derivation #fourmolu

@jberthold jberthold self-assigned this Apr 4, 2024
@jberthold jberthold changed the title Booster-532: align fourmolu, revive hlint Booster-532: align fourmolu and hlint versions Apr 4, 2024
@jberthold
Copy link
Member Author

The changes to the trailing $ look horrible! And for some reason this only happens within the context of the project, not with isolated files outside of it (with the same configuration file available)

@jberthold
Copy link
Member Author

For posterity: https://github.com/fourmolu/fourmolu#language-extensions-dependencies-and-fixities explains (in brief) that fourmolu rearranges and re-indents operator chains if it does not know their fixities (because of reexporting and NoImplicitPrelude) - I adjusted this in the fourmolu.yaml

@jberthold jberthold marked this pull request as ready for review April 4, 2024 09:24
@@ -239,9 +238,9 @@
mkShell {
nativeBuildInputs = [
(haskell.lib.justStaticExecutables
# (ghcVersion pkgs).fourmolu
(import nixpkgs2305 { inherit system; }).haskellPackages.fourmolu_0_12_0_0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the import of nixpkgs2305 should be removed entirely now that we no longer need the old versions

@jberthold jberthold merged commit 847aad9 into master Apr 4, 2024
7 checks passed
@jberthold jberthold deleted the booster-532-align-fourmolu branch April 4, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants