Remove option to include lemmas at build time #979
+187
−331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
automergerpr-permission-manager bot
pushed a commit
to runtimeverification/k
that referenced
this pull request
Mar 14, 2025
This PR factors out the ability to add KAST level modules to the RPC server via `CTermSymbolic`, so that the user doesn't need to manually do the conversions needed for adding such modules. The `APRProver` is refactored to use this new `CTermSymbolic.add_module` as well. This is part of runtimeverification/kontrol#977, and blocking runtimeverification/kontrol#979.
…bility to include lemmas at build time
…to RpcOptions, deprecate --extra-module
…ded at prove time
…mport statements for new lemmas structure
…ith new lemmas structure
ehildenb
force-pushed
the
remove-build-lemmas
branch
from
80471c3 to
b6490c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocked on: runtimeverification/k#4771Blocked on: runtimeverification/evm-semantics#2722Blocked on: runtimeverification/k#4772
Part of: #977
This is a BREAKING CHANGE, so it's pulled into it's own PR. In particular, the ability to include lemmas at build time via
kontrol build ... --require ... --module-import ...is removed in this PR. Instead, users are expected to use thekontrol prove ... --extra-module ...feature introduced here: #883.We need to make sure that KaaS has the appropriate change in its interface, and that the verification engineers are aware of the change.