Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement building from sources #45

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Implement building from sources #45

wants to merge 2 commits into from

Conversation

shssoichiro
Copy link

This cargo feature existed but was never actually implemented. This feature was necessary for the Rust AV1 Analyzer I'm working on, so that I can ensure that the accounting feature set is included (which is also a part of this changeset).

@shssoichiro
Copy link
Author

I would love some help if someone is more familiar with getting things to build properly, though. The CI is failing and I'm having trouble figuring it out.

Locally, -features build_sources works, but it fails the tests in CI. With no features, it fails both locally and in CI, but with different errors.

env::set_var("SYSTEM_DEPS_BUILD_INTERNAL", "always");
system_deps::Config::new()
.add_build_internal("aom", |lib, version| {
// Actually build the library here
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here you should call build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants