Hack up a -jra version of this crate
#171
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mention the new `decode_` functions in the crate level docs.
IMO this crate is close to ready for release. Introduce an API script to help verify the exact API.
Run the recently introduced script with: contrib/check-for-api-changes.sh and commit the files. No manual changes.
We made a bunch of changes to the error types in an effort to make it possible to update them without breaking semver - this is a lost cause. Simplify the error types and just fucking commit to the API. While we are at it make the `error` module private because it is a code organization thing only. Re-export all the error types at the crate root.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just Release Already.
If you do not have a PR up within two weeks @Kixunil that puts this crate in a releasable state then I am forking and releasing
hex-conservative-jra 1.0with what is in this PR.If we then still cannot come to an agreement I will fork all the way up to
rust-bitcoin. I'm done arguing with you bro, we need to just fucking release already.You have two weeks.