-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add blog post about i686-pc-windows-gnu demotion #1523
Open
Noratrieb
wants to merge
3
commits into
rust-lang:master
Choose a base branch
from
Noratrieb:demoting-i686-pc-windows-gnu
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add blog post about i686-pc-windows-gnu demotion #1523
Noratrieb
wants to merge
3
commits into
rust-lang:master
from
Noratrieb:demoting-i686-pc-windows-gnu
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
jieyouxu
reviewed
Mar 12, 2025
davidtwco
approved these changes
Mar 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/ my and @jieyouxu's comments
mati865
reviewed
Mar 24, 2025
Note that posts were moved to the |
a8706a4
to
7d26df0
Compare
Rebased and adjusted the expected version number. I suggest merging it somewhere between 1.87 and 1.88, so we have about ~7 weeks to wait. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@workingjubilee @mati865 you might have feedback about the content (or anyone else is welcome to give feedback too)
I'm unsure about the timeline on when we want to merge this. I'd suggest to merge it close to the 1.87.0 release (where my demotion PR will arrive if everything goes according to plan). It won't immediately impact users, so it doesn't benefit from advanced notification.
@wesleywiser @davidtwco
Rendered