Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2025h1 project goals March update #1546

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

lqd
Copy link
Member

@lqd lqd commented Apr 2, 2025

This is the March 2025h1 project goals update. It's partially generated to collect all the individual goal updates posted by the goal owners, and hand tweaked (some manual layout tweaking was required, as well as some of the content that jumped out).

I think the new blog setup has degraded link detection? I've had to manually mark some markdown links for them to be detected. I don't remember having to do this before, but could be wrong.

Some other missing links were just because the content comes from github, and that has its own set of linkifiers that we don't have on the blog: we'll have to take care of these in the automation collecting the project goals updates into these blog posts. I manually fixed these for the flagship goals though.

cc @nikomatsakis

Rendered

@senekor
Copy link
Contributor

senekor commented Apr 2, 2025

I made a bunch of changes to the blog setup recently, so if there's a regression I will try to fix it. Could you explain more what the problem was? Link detection? We still use the same markdown parser library, so I'm not sure what would've caused it.

@senekor
Copy link
Contributor

senekor commented Apr 2, 2025

Ah, I suppose it's about adding the <> around plain URLs in the "fix linkification" commits.

@lqd
Copy link
Member Author

lqd commented Apr 2, 2025

Auto-linkifying probably, so not related to markdown parsing: noticing a https://... piece of text and turning it into a link. Again, I could be wrong.

@senekor
Copy link
Contributor

senekor commented Apr 2, 2025

Sorry for not being clear, the markdown parsing library also outputs the html for us, looks like this:

let contents = comrak::markdown_to_html(contents, &options);

I don't think we do any additional / custom linkification.

It's possible that the comrak library was updated in the meantime and somehow changed its behavior in this regard. I'll have a look later.

@lqd lqd force-pushed the march-goals-updates branch from 70ca25e to cb84f33 Compare April 2, 2025 17:04
@senekor
Copy link
Contributor

senekor commented Apr 2, 2025

I checked out an older commit (Nov. 2024), copy-pasted the content and the plain URLs still weren't linkfied. So I doubt this is a regression. Or it would've happened a long time ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants