fix: highlight extern crate in doc comments
#19137
Open
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
lnicola
approved these changes
Feb 11, 2025
|
Hm, in Rust code we mark these as namespaces with |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Veykril
reviewed
Feb 14, 2025
Veykril
reviewed
Feb 14, 2025
|
Thank you for the suggestion. I've updated the patch. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm new to this project and still getting familiar with the codebase.
I've added a branch to ensure that
extern crate Krate;is highlighted as a module inhighlight_name_ref_by_syntax, and I've updated the corresponding doctest expectations accordingly. If I've misunderstood the intended behavior or made any mistakes in these changes, please let me know. I'm happy to adjust the patch as needed.Fixes #19041.