Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not intersect spans coming from different contexts #13942

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

samueltardieu
Copy link
Contributor

@samueltardieu samueltardieu commented Jan 4, 2025

The code should not attempt to obtain a snippet by capping the function signature span with its identifier span without checking that they are in the same context.

This is the only instance I could identify where placeholders were used instead of the real snippet when running the CI lintcheck. Moreover, the placeholders were not even used, as they snippet was obtained prematurely.

Found in the context of #13941

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Jan 4, 2025

r? @dswij

rustbot has assigned @dswij.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 4, 2025
The code should not attempt to obtain a snippet by capping the
function signature span with its identifier span without checking that
they are in the same context.
Copy link
Member

@dswij dswij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dswij dswij added this pull request to the merge queue Jan 10, 2025
Merged via the queue into rust-lang:master with commit 716a3a4 Jan 10, 2025
9 checks passed
@samueltardieu samueltardieu deleted the push-mpvyrnsnopuu branch January 10, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants